refactor: remove needless collect (#14474)

Co-authored-by: Fabian-Lars <github@fabianlars.de>

Author: Tunglies

.changes/fix-needles-collect.md

@@ -0,0 +1,8 @@
+---
+"tauri": patch:perf
+"tauri-cli": patch:perf
+"tauri-bundler": patch:perf
+"@tauri-apps/cli": patch:perf
+---
+
+refactor: remove needless collect. No user facing changes.

crates/tauri-bundler/src/bundle.rs

@@ -241,11 +241,10 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<Bundle>> {
     return Ok(bundles);
   }
 
-  let bundles_wo_updater = bundles
+  let finished_bundles = bundles
     .iter()
     .filter(|b| b.package_type != PackageType::Updater)
-    .collect::<Vec<_>>();
-  let finished_bundles = bundles_wo_updater.len();
+    .count();
   let pluralised = if finished_bundles == 1 {
     "bundle"
   } else {

crates/tauri-cli/src/icon.rs

@@ -280,19 +280,15 @@ pub fn command(options: Options) -> Result<()> {
     android(&source, &input, manifest, &bg_color_string, &out_dir)
       .context("Failed to generate android icons")?;
   } else {
-    for target in png_icon_sizes
-      .into_iter()
-      .map(|size| {
-        let name = format!("{size}x{size}.png");
-        let out_path = out_dir.join(&name);
-        PngEntry {
-          name,
-          out_path,
-          size,
-        }
-      })
-      .collect::<Vec<PngEntry>>()
-    {
+    for target in png_icon_sizes.into_iter().map(|size| {
+      let name = format!("{size}x{size}.png");
+      let out_path = out_dir.join(&name);
+      PngEntry {
+        name,
+        out_path,
+        size,
+      }
+    }) {
       log::info!(action = "PNG"; "Creating {}", target.name);
       resize_and_save_png(&source, target.size, &target.out_path, None, None)?;
     }

crates/tauri/src/process.rs

@@ -116,7 +116,7 @@ fn restart_macos_app(current_binary: &std::path::Path, env: &Env) {
           .and_then(|v| v.as_string())
         {
           if let Err(e) = Command::new(macos_directory.join(binary_name))
-            .args(env.args_os.iter().skip(1).collect::<Vec<_>>())
+            .args(env.args_os.iter().skip(1))
             .spawn()
           {
             log::error!("failed to restart app: {e}");