feat(core): improve and cleanup the Error enum (#3748)

Author: lucasfernog

.changes/error-send-sync.md

@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+The `Error` enum is now `Send + Sync`.

.changes/runtime-error-sync.md

@@ -0,0 +1,5 @@
+---
+"tauri-runtime": patch
+---
+
+Force `Error` boxed errors to be `Sync`.

.changes/simplify-setup-requirement-error.md

@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+The `App::setup` closure can now return a boxed error directly.

core/tauri-runtime-wry/src/lib.rs

@@ -550,7 +550,7 @@ impl<T: UserEvent> ClipboardManager for ClipboardManagerWrapper<T> {
 /// Wrapper around a [`wry::application::window::Icon`] that can be created from an [`WindowIcon`].
 pub struct WryIcon(WryWindowIcon);
 
-fn icon_err<E: std::error::Error + Send + 'static>(e: E) -> Error {
+fn icon_err<E: std::error::Error + Send + Sync + 'static>(e: E) -> Error {
   Error::InvalidIcon(Box::new(e))
 }
 

core/tauri-runtime/src/lib.rs

@@ -98,7 +98,7 @@ pub enum UserAttentionType {
 pub enum Error {
   /// Failed to create webview.
   #[error("failed to create webview: {0}")]
-  CreateWebview(Box<dyn std::error::Error + Send>),
+  CreateWebview(Box<dyn std::error::Error + Send + Sync>),
   /// Failed to create window.
   #[error("failed to create window")]
   CreateWindow,
@@ -118,16 +118,16 @@ pub enum Error {
   #[cfg(feature = "system-tray")]
   #[cfg_attr(doc_cfg, doc(cfg(feature = "system-tray")))]
   #[error("error encountered during tray setup: {0}")]
-  SystemTray(Box<dyn std::error::Error + Send>),
+  SystemTray(Box<dyn std::error::Error + Send + Sync>),
   /// Failed to load window icon.
   #[error("invalid icon: {0}")]
-  InvalidIcon(Box<dyn std::error::Error + Send>),
+  InvalidIcon(Box<dyn std::error::Error + Send + Sync>),
   /// Failed to get monitor on window operation.
   #[error("failed to get monitor")]
   FailedToGetMonitor,
   /// Global shortcut error.
   #[error(transparent)]
-  GlobalShortcut(Box<dyn std::error::Error + Send>),
+  GlobalShortcut(Box<dyn std::error::Error + Send + Sync>),
   #[error("Invalid header name: {0}")]
   InvalidHeaderName(#[from] InvalidHeaderName),
   #[error("Invalid header value: {0}")]

core/tauri/src/api/cli.rs

@@ -90,7 +90,7 @@ impl Matches {
 /// use tauri::api::cli::get_matches;
 /// tauri::Builder::default()
 ///   .setup(|app| {
-///     let matches = get_matches(app.config().tauri.cli.as_ref().unwrap(), app.package_info()).unwrap();
+///     let matches = get_matches(app.config().tauri.cli.as_ref().unwrap(), app.package_info())?;
 ///     Ok(())
 ///   });
 /// ```

core/tauri/src/api/ipc.rs

@@ -125,7 +125,7 @@ pub fn serialize_js_with<T: Serialize, F: FnOnce(&str) -> String>(
 ///       "console.log({}, {})",
 ///       serialize_js(&Foo { bar: "bar".to_string() }).unwrap(),
 ///       serialize_js(&Bar { baz: 0 }).unwrap()),
-///     ).unwrap();
+///     )?;
 ///     Ok(())
 ///   });
 /// ```

core/tauri/src/api/path.rs

@@ -125,7 +125,7 @@ impl BaseDirectory {
 /// use tauri::Manager;
 /// tauri::Builder::default()
 ///   .setup(|app| {
-///     let path = tauri::api::path::parse(&app.config(), app.package_info(), &app.env(), "$HOME/.bashrc").unwrap();
+///     let path = tauri::api::path::parse(&app.config(), app.package_info(), &app.env(), "$HOME/.bashrc")?;
 ///     assert_eq!(path.to_str().unwrap(), "/home/${whoami}/.bashrc");
 ///     Ok(())
 ///   });
@@ -202,7 +202,7 @@ pub fn parse<P: AsRef<Path>>(
 ///       &app.env(),
 ///       "path/to/something",
 ///       Some(BaseDirectory::Config)
-///     ).expect("failed to resolve path");
+///     )?;
 ///     assert_eq!(path.to_str().unwrap(), "/home/${whoami}/.config/path/to/something");
 ///     Ok(())
 ///   });

core/tauri/src/api/process.rs

@@ -46,7 +46,7 @@ pub use command::*;
 ///
 /// tauri::Builder::default()
 ///   .setup(|app| {
-///     let current_binary_path = current_binary(&app.env()).unwrap();
+///     let current_binary_path = current_binary(&app.env())?;
 ///     Ok(())
 ///   });
 /// ```

core/tauri/src/api/shell.rs

@@ -101,7 +101,7 @@ impl Program {
 /// tauri::Builder::default()
 ///   .setup(|app| {
 ///     // open the given URL on the system default browser
-///     open(&app.shell_scope(), "https://github.com/tauri-apps/tauri", None).unwrap();
+///     open(&app.shell_scope(), "https://github.com/tauri-apps/tauri", None)?;
 ///     Ok(())
 ///   });
 /// ```