fix(bundler): debian failing to load icns icon, closes #3062 (#4009)

lucasfernog · web-flow · commit de444b15d222 · 2022-04-30T10:53:29.000-03:00
* fix(bundler): debian failing to load icns icon, closes #3062 * fix change file
diff --git a/.changes/fix-debian-icns-load.md b/.changes/fix-debian-icns-load.md
@@ -0,0 +1,5 @@
+---
+"tauri-bundler": patch
+---
+
+Ignore errors when loading `icns` files in the `.deb` package generation.
diff --git a/tooling/bundler/src/bundle/linux/debian.rs b/tooling/bundler/src/bundle/linux/debian.rs
@@ -320,9 +320,10 @@ fn generate_icon_files(settings: &Settings, data_dir: &Path) -> crate::Result<BT
           path: dest_path,
         };
         if !icons.contains(&deb_icon) {
-          let icon = icon_family.get_icon_with_type(icon_type)?;
-          icon.write_png(common::create_file(&deb_icon.path)?)?;
-          icons.insert(deb_icon);
+          if let Ok(icon) = icon_family.get_icon_with_type(icon_type) {
+            icon.write_png(common::create_file(&deb_icon.path)?)?;
+            icons.insert(deb_icon);
+          }
         }
       }
     } else {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"tauri-bundler": patch
 +---
++
 +Ignore errors when loading `icns` files in the `.deb` package generation.
Original file line number	Diff line number	Diff line change
`@@ -320,9 +320,10 @@ fn generate_icon_files(settings: &Settings, data_dir: &Path) -> crate::Result<BT`
`320`	`320`	`path: dest_path,`
`321`	`321`	`};`
`322`	`322`	`if !icons.contains(&deb_icon) {`
`323`		`- let icon = icon_family.get_icon_with_type(icon_type)?;`
`324`		`- icon.write_png(common::create_file(&deb_icon.path)?)?;`
`325`		`- icons.insert(deb_icon);`
	`323`	`+ if let Ok(icon) = icon_family.get_icon_with_type(icon_type) {`
	`324`	`+ icon.write_png(common::create_file(&deb_icon.path)?)?;`
	`325`	`+ icons.insert(deb_icon);`
	`326`	`+ }`
`326`	`327`	`}`
`327`	`328`	`}`
`328`	`329`	`} else {`