Skip to content

Commit

Permalink
revert: revert #10969, consistent product_code (#11182)
Browse files Browse the repository at this point in the history
closes #11178
  • Loading branch information
amrbashir authored Sep 30, 2024
1 parent 0c87e05 commit e10fdb7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changes/revert-10969-consistent-update-code.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tauri-bundler": patch:bug
---

Revert recent change that generated MSI installers with the same product code which prevented updates to happen, it is now ranomized like it previously was.
2 changes: 1 addition & 1 deletion crates/tauri-bundler/src/bundle/windows/msi/main.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
<Product
Id="{{product_code}}"
Id="*"
Name="{{product_name}}"
UpgradeCode="{{upgrade_code}}"
Language="!(loc.TauriLanguage)"
Expand Down
7 changes: 0 additions & 7 deletions crates/tauri-bundler/src/bundle/windows/msi/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -562,13 +562,6 @@ pub fn build_wix_app_installer(
)
});
data.insert("upgrade_code", to_json(upgrade_code.to_string()));

let product_code = Uuid::new_v5(
&Uuid::NAMESPACE_DNS,
settings.bundle_identifier().as_bytes(),
)
.to_string();
data.insert("product_code", to_json(product_code.as_str()));
data.insert(
"allow_downgrades",
to_json(settings.windows().allow_downgrades),
Expand Down

0 comments on commit e10fdb7

Please sign in to comment.