Skip to content

Updater refactor w/ async? #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lemarier opened this issue Jul 16, 2021 · 2 comments
Closed

Updater refactor w/ async? #2223

lemarier opened this issue Jul 16, 2021 · 2 comments

Comments

@lemarier
Copy link
Member

lemarier commented Jul 16, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

With the latest changes to our Linux implementations, it gets harder to spawn a thread, especially for dialogs.

In #2222 we fixed with the glib::MainContext

The big drawback with that is it runs on the main GtkThread, which means it locks the app run.

Having slow updater endpoints will cause the app to be slower to open (on Linux)

Describe the solution you'd like
I'm not sure?

Describe alternatives you've considered
N/A

Additional context
@lucasfernog
Copy link
Member

@lemarier shouldn't the glib::MainContext be used only to render the dialog? that would keep the API call on a separate task.

@lucasfernog
Copy link
Member

I'll see if I can move the context usage to the dialog API itself.

lucasfernog added a commit that referenced this issue Aug 14, 2021
@lucasfernog
refactor(core): handle dialog threading internally, closes #2223
57df90d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasfernog @lemarier