`beforeDevCommand` is not killed on app exit

[harshkhandeparkar]

Describe the bug

Closing the tauri dev app window doesn't close the dev server started with beforeDevCommand (confirmed using the create-react-app template for create-tauri-app)

To Reproduce

Steps to reproduce the behavior:

1. Create an app using create-react-app template
2. Run tauri dev
3. Close the app window using the x button or alt + f4
4. Run tauri dev again.

Expected behavior

The dev server should be gracefully shut down when the app is closed.

[rondonjon]

gracefully shut down

Gracefully or not, please terminate the darn process :-)

I cannot reproduce the behavior reliably. Sometimes the dev server gets shut down, sometimes it keeps running. This is esepcially annoying while debugging: trying to force the app to do something, wondering why the app is acting so strange and then realizing a few minutes later that none of the code changes were actually deployed.

[frnco]

Gracefully or not, please terminate the darn process :-)
Couldn't agree more.

I cannot reproduce the behavior reliably. Sometimes the dev server gets shut down, sometimes it keeps running. This is esepcially annoying while debugging: trying to force the app to do something, wondering why the app is acting so strange and then realizing a few minutes later that none of the code changes were actually deployed.
For me the beforeDevCommand always closes properly, I'm on Arch Linux and mostly using Mint, not React, but that means there are some conditions for this problem to happen. To add some info on my system so it may help figure out what's different, it's Arch Linux, x64, I'm running tauri from cargo(i.e. cargo tauri dev), and I started a bunch of small projects using Tauri to test different combinations, which means I've had a lot (And I mean A LOT) of stuff on beforeDevCommand, never had any problem, all of the commands closed properly when I exited the Tauri app, some of the commands I can recall were vite for running VueJS, mint, elm... There were so many things I don't even remember it all. I'll check React later and report here just for completeness.

And as this points to something specific being necessary to trigger this failure in terminating the child process, I believe some tauri info would be nice here, or at least the OS and what the beforeDevCommand actually runs.

[lucasfernog]

I couldn't reproduce this one yet, can one of you see if #2883 fixes it?
I assume this is on Windows so that's what i'm testing, no one pasted a tauri info output.

[SeedyROM]

@lucasfernog Here's my tauri info for the same issue, I consistently get this bug.

Operating System - Manjaro, version 21.2.2 X64

Node.js environment
  Node.js - 16.13.2
  @tauri-apps/cli - 1.0.0-rc.5
  @tauri-apps/api - 1.0.0-rc.1

Global packages
  npm - 8.3.0
  pnpm - 6.23.3
  yarn - 1.22.15

Rust environment
  rustup - 1.24.3
  rustc - 1.60.0-nightly
  cargo - 1.60.0-nightly
  toolchain - nightly-x86_64-unknown-linux-gnu 

App directory structure
/src
/node_modules
/build
/public
/src-tauri

App
  tauri - 1.0.0-rc.3 (no lockfile)
  tauri-build - no manifest (no lockfile)
  tao - no manifest (no lockfile)
  wry - no manifest (no lockfile)
  build-type - bundle
  CSP - unset
  distDir - ../build
  devPath - http://localhost:3000/
  framework - React

[Janaka-Steph]

I also always got it.

▶ cargo tauri info

Operating System - Mac OS, version 12.2.1 X64

Node.js environment
Node.js - 16.14.0
@tauri-apps/cli - 1.0.0-rc.5
@tauri-apps/api - 1.0.0-rc.1

Global packages
npm - 8.1.4
pnpm - Not installed
yarn - 1.22.17

Rust environment
rustup - 1.24.3
rustc - 1.58.1
cargo - 1.58.0
toolchain - stable-aarch64-apple-darwin

App directory structure
/node_modules
/public
/scripts
/.github
/src-tauri
/build
/.git
/.idea
/src

App
tauri - 1.0.0-rc.3
tauri-build - 1.0.0-rc.3
tao - 0.6.2
wry - 0.13.2
build-type - bundle
CSP - default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
distDir - ../build
devPath - http://localhost:3003/
framework - React
bundler - Webpack

[nothingismagick]

So this does seem to look like a react issue. I think we should go through and verify other non-"reacty" frameworks and see if its just particular here, or relevant for others.

[FabianLars]

It is a general problem, it's just worse with some frameworks/bundlers. For example i have the same problem with vitejs (no matter the frontend), but only if i close the app with ctrl+c. This also renders the terminal completely unusable for me.