Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Better error message when using the updater on Linux #3817

Closed
corentinguilloteau opened this issue Mar 30, 2022 · 3 comments
Closed
Labels
type: documentation Need to update the API documentation type: feature request

Comments

@corentinguilloteau
Copy link

Describe the problem

When trying to use the updater on Linux, I encountered the error Unsupported operating system or platform. The problem was that I ran my application after installing it with the .deb package and not directly from the AppImage.

I spent some time figuring out where the problem was from because this error message is the same as the error message used if target_arch or target_os is unsupported.

Describe the solution you'd like

I think using a different error message for those two cases would be really helpful.

Also, it could be profitable to add a note in the documentation to inform developers that a user on Linux need to run the AppImage if he wants to use the updater.

Alternatives considered

No response

Additional context

No response

@JonasKruckenberg
Copy link
Member

I see this as a documentation issue, not something addressable through code, but yes you are correct we should be more forthcoming about which packaging formats support updating and which do not.

@JonasKruckenberg JonasKruckenberg added the type: documentation Need to update the API documentation label Mar 31, 2022
@corentinguilloteau
Copy link
Author

Wouldn't it also be possible to add a new Error here and use it here instead of the Error::UnsupportedPlatform ?

@FabianLars
Copy link
Member

Ideally the app wouldn't even include the updater code for non appimage bundles, but that would mean that we'd have to build the binary twice :((

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Need to update the API documentation type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants