Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Rename one of two WindowBuilders #3827

Closed
joepio opened this issue Mar 31, 2022 · 0 comments
Closed

[docs] Rename one of two WindowBuilders #3827

joepio opened this issue Mar 31, 2022 · 0 comments
Labels
type: documentation Need to update the API documentation

Comments

@joepio
Copy link
Contributor

joepio commented Mar 31, 2022

There are two WindowBuilders exported: tauri::window::WindowBuilder and tauri::WindowBuilder. One is a Struct, the other a Trait. Took me longer than I want to admit that I had imported the Trait, not the Struct, which was why everything went wrong.

I think the best solution is to rename one of both.
@joepio joepio added the type: documentation Need to update the API documentation label Mar 31, 2022
lucasfernog added a commit that referenced this issue Mar 31, 2022
@lucasfernog
fix(tauri): export WindowBuilder struct instead of trait, closes #3827
9fd5eec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation Need to update the API documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joepio