Skip to content

[bug] Unnecessary folder for resources on windows #4087

@gimait

Description

@gimait

Describe the bug

Resources are not added correctly to the Wix file, producing a faulty bundle on Windows builds.

Reproduction

  1. Add a resource file to tauri.conf.json.
  2. Create a Windows build.
  3. Install the application using the generated .msi file.

Expected behavior

When adding a resource folder in the path ../res, the resources should be installed in a folder called _up_/res.
I would also expect that a file ../res/resource1.txt would appear in the path _up_/res/resource1.txt.
This is for consistency with other builds and the expected behaviour for the dev environment.

In the current state of the bundler, the generated wix file ignores the standard defined in

pub fn resource_relpath(path: &Path) -> PathBuf {

It also adds an extra directory for each file with its file name, moving the resources to folders with their own name.

This means that a resource ../res/resource1.txt gets copied to res/resource1.txt/resource1.txt, rather than the correct _up_/res/resource1.txt.

Platform and versions

Environment
  › OS: Windows 10.0.19043 X64
  › Webview2: 101.0.1210.39
  › MSVC: 
      - Visual Studio Community 2019
  › Node.js: 18.0.0
  › npm: 8.6.0
  › pnpm: 6.11.0
  › yarn: 1.22.15
  › rustup: 1.24.3
  › rustc: 1.59.0
  › cargo: 1.59.0
  › Rust toolchain: stable-x86_64-pc-windows-msvc 

Packages
  › @tauri-apps/cli [NPM]: 1.0.0-rc.10
  › @tauri-apps/api [NPM]: 1.0.0-rc.5
  › tauri [RUST]: 1.0.0-rc.8,
  › tauri-build [RUST]: 1.0.0-rc.7,
  › tao [RUST]: 0.8.3,
  › wry [RUST]: 0.15.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../build
  › devPath: http://localhost:3000/
  › framework: React

Stack trace

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions