Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] resources are missing after installer upgrade (works after re-install) #4182

Closed
nathanbabcock opened this issue May 20, 2022 · 2 comments
Assignees

Comments

@nathanbabcock
Copy link

nathanbabcock commented May 20, 2022

Describe the bug

When upgrading from a previous installation, the resources specified in tauri.conf.json are skipped. Uninstalling and re-installing the program fixes it.

I saw this bug on the latest beta/production release of my application. There was a smaller update this Monday (5/16) that worked correctly. Maybe this is a regression in recent changes to the installer?

I can post the diff of tauri.conf.json for the previous and current version if it is helpful.

Reproduction

  1. Download and install v0.9.2 of the application: https://hypetrigger-downloads.s3.amazonaws.com/Hypetrigger_0.9.2_x64_en-US.msi.zip

  2. Check C:\Program Files\hypetrigger to see that all resources have been bundled (tensorflow.dll, tensorflow.lib, ffmpeg.exe, and data folder)
    hypetrigger-0 9 2-program-files

  3. Either accept the auto-update request to v0.10.0, or download the v0.10.0 installer (both approaches cause the bug): https://hypetrigger-downloads.s3.amazonaws.com/Hypetrigger_0.10.0_x64_en-US.msi.zip

  4. After installation, attempt to launch Hypetrigger.exe

  5. Error: tensorflow.dll is not installed

tensorflow dll

  1. Check C:\Program Files\hypetrigger. Notice that all the assets are missing from this version of the installation, even though all the same resources are present in tauri.conf.json

hypetrigger-missing

  1. Run the 0.10.0 installer again to uninstall the program, and then reinstall from scratch
  2. Launch Hypetrigger.exe. This time, the app loads correctly and all the resources are correctly located in the installation folder.

Expected behavior

The installer should always bundle the correct resources when installing.

Platform and versions

$ npm run tauri info

> hypetrigger@0.9.2 tauri
Environment
  › OS: Windows 10.0.19044 X64
  › Webview2: 101.0.1210.47
  › MSVC:
      - Visual Studio Community 2019
      - Visual Studio Build Tools 2017
  › Node.js: 14.18.0
  › npm: 8.7.0
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.24.3
  › rustc: 1.60.0
  › cargo: 1.60.0
  › Rust toolchain: stable-x86_64-pc-windows-msvc 

Packages
  › @tauri-apps/cli [NPM]: 1.0.0-rc.11
  › @tauri-apps/api [NPM]: 1.0.0-rc.5
  › tauri [RUST]: 1.0.0-rc.6,
  › tauri-build [RUST]: 1.0.0-rc.5,
  › tao [RUST]: 0.7.0,
  › wry [RUST]: 0.14.0,

App
  › build-type: bundle
  › CSP: default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self'; worker-src 'self' blob: https://tauri.localhost/; script-src 'self' 'unsafe-eval' https://unpkg.com
  › distDir: ../dist
  › devPath: http://localhost:3000/

App directory structure
  ├─ .git
  ├─ dist
  ├─ node_modules
  ├─ scripts
  ├─ src
  └─ src-tauri

Stack trace

No response

Additional context

Did not happen on any previous version of the installer, as recently as 5/20/22

@nathanbabcock
Copy link
Author

@lucasfernog this is great news and super fast turnaround. Thank you! 🙏

@nathanbabcock
Copy link
Author

I can confirm this fix worked correctly. When upgrading my app from v0.10.0 -> v0.10.1 all the correct files were automatically copied during installation and it worked smoothly, no issues! 🎉

Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants