[bug] The bug of resizing the window in the javascript API

[57321]

Describe the bug

First, it was normal in v1.0.0.

In v1.0.1

When I resize the window height it always gets 20px more.

before

after

so. Is this a feature or a bug?

Reproduction

No response

Expected behavior

No response

Platform and versions

Operating System - Windows, version 10.0.18362 X64
Webview2 - 103.0.1264.37
Visual Studio Build Tools - Not installed

Node.js environment
  Node.js - 14.18.0
  @tauri-apps/cli - 1.0.0-beta.10 (outdated, latest: 1.0.1)
  @tauri-apps/api - 1.0.1

Global packages
  npm - 6.14.15
  pnpm - 7.3.0
  yarn - 1.22.10

Rust environment
  rustc - 1.61.0
  cargo - 1.61.0

Rust environment
  rustup - 1.24.3
  rustc - 1.61.0
  cargo - 1.61.0
  toolchain - stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)

App directory structure
/.git
/.vscode
/dist
/node_modules
/public
/src
/src-tauri

App
  tauri.rs - 1.0.2
`tauri.conf.json` error on ``: Additional property '$schema' is not allowed
`tauri.conf.json` error on `tauri > bundle > macOS`: Additional property 'providerShortName' is not allowed

Stack trace

No response

Additional context

No response

[FabianLars]

Looks like tauri-apps/tao#194 is back 👀

p.s. you should update your tauri cli

[57321]

update cli.

Environment
  › OS: Windows 10.0.18362 X64
  › Webview2: 103.0.1264.37
  › MSVC: 
      - Visual Studio ���ɹ��� 2019
  › Node.js: 14.18.0
  › npm: 6.14.15
  › pnpm: 7.3.0
  › yarn: 1.22.10
  › rustup: 1.24.3
  › rustc: 1.61.0
  › cargo: 1.61.0
  › Rust toolchain: stable-x86_64-pc-windows-msvc 

Packages
  › @tauri-apps/cli [NPM]: 1.0.2
  › @tauri-apps/api [NPM]: 1.0.1
  › tauri [RUST]: 1.0.2,
  › tauri-build [RUST]: 1.0.2,
  › tao [RUST]: 0.12.0,
  › wry [RUST]: 0.19.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:3000/
  › framework: Vue.js

App directory structure
  ├─ .git
  ├─ .vscode
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src
  └─ src-tauri

[amrbashir]

I can't reproduce this at all. Please open the devtools console, and check window.innerWidth and window.innerHeight

[57321]

I changed to another computer, but it's win11 system.
Create new project.

What would you want other?

Environment
  › OS: Windows 10.0.22000 X64
  › Webview2: 100.0.1185.29
  › MSVC:
      - Visual Studio ���ɹ��� 2019
  › Node.js: 17.4.0
  › npm: 8.3.1
  › pnpm: 7.4.0
  › yarn: 1.22.4
  › rustup: 1.24.3
  › rustc: 1.62.0
  › cargo: 1.62.0
  › Rust toolchain: stable-x86_64-pc-windows-msvc 

Packages
  › @tauri-apps/cli [NPM]: 1.0.2
  › @tauri-apps/api [NPM]: 1.0.1
  › tauri [RUST]: 1.0.2,
  › tauri-build [RUST]: 1.0.2,
  › tao [RUST]: 0.12.1,
  › wry [RUST]: 0.19.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:3000/
  › framework: Vue.js

App directory structure
  ├─ .vscode
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src
  └─ src-tauri

[amrbashir]

Are you using custom scaling?

[57321]

Are you using custom scaling?

Do you mean windows custom scaling？ The setting is 100%

[amrbashir]

I can definitely reproduce this with Tauri and tauri only. It works fine in tao, it works fine in wry but not in tauri.

tao uses AdjustWindowRectEx from win32 APIs here to determine how big the window should be based on required client size, titlebars and borders.

I tried tracking the results of this function call and here is what I found:

1. Initially set the size in tauri.conf.json to 800,60 and AdjustWindowRect will return

   [D:\dev\tao\src\platform_impl\windows\util.rs:116] &rect = RECT {
       left: -8, # left border
       top: -31, # titlebar height + menu bar if it exists + top border which is 8
       right: 808, # window inner width + right border which is 8
       bottom: 68, # window inner height + bottom border which is 8
   }

2. Then we try to set the window size through the API to 800,60 (same size as before) and here is what I don't understand

   [D:\dev\tao\src\platform_impl\windows\util.rs:116] &rect = RECT {
       left: -8, # left border -> same as above
       top: -51, # titlebar height + top border -> NOT THE SAME !!!!
       right: 808, # window inner width + right border -> same as above
       bottom: 68, # window inner height + bottom border -> same as above
   }

you can see that the titlebar height has increased, hello Windows? why?

Anyhow, you'd expect if you try to set the size again, the titlebar size will increase even more but NO, the titlebar height stays as -51 and for the entirety of the window life span, setSize will actually work as expected, So the bug is only in the first invocation but I have no idea what is going on.

[amrbashir]

I think I found the issue, it was this commit 5105b42 which adds an empty menu bar on Windows, and AdjustWindowRect will account for its size.

It doesn't happen initially because the menu is added after the window has been created so the first call to AdjustWindowRect it won't add the menu bar size but subsequent calls which happens after the empty menubar has been added, will add the menu bar size.

I will push the fix soon but for your current project, you need to add the menu on macOS only, use Menu::os_default for all paltforms, not just macOS or remove the menu bar altogether.

Something like this

let mut app = tauri::Builder::default();
#[cfg(target_os = "macOS")]
{
  app = app.menu(tauri::Menu::os_default(&context.package_info().name));
}
app
  .run(context)
  .expect("error while running tauri application");