Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support binstall for tauri-cli #4651

Closed
erayerdin opened this issue Jul 11, 2022 · 5 comments · Fixed by #4817
Closed

[feat] Support binstall for tauri-cli #4651

erayerdin opened this issue Jul 11, 2022 · 5 comments · Fixed by #4817
Assignees
Labels
status: in progress Implementation is proceeding smoothly type: feature request

Comments

@erayerdin
Copy link

Describe the problem

In order to install tauri-cli, you do cargo install tauri-cli, which pulls the source and dependencies and compiles them. This is too slow and consuming too much CPU and memory resource.

Describe the solution you'd like

cargo-binstall fetches already-compiled binaries and installs them instead of compiling from zero.

Alternatives considered

cargo-quickinstall is another alternative although I have not used it.

Additional context

No response

@FabianLars
Copy link
Member

Yeah i thought about this stuff too, the problem is that our CI for publishing the CLI already takes ages (40 minutes after everything else was published) and this would add another ~30 minutes on top :/

But still, we should look into adding it anyway, this is like the only real downside of cargo install for most users.

@JonasKruckenberg
Copy link
Member

JonasKruckenberg commented Jul 11, 2022

I think this is a great idea, the problem with CI times is real though, so adding support for this is out of the question right now imo.
But after we had someone look at our untenable CI situation we should definitely consider this!

@erayerdin
Copy link
Author

Mine is just an idea. I don't know the internals of this project but I can see you are using Github Actions.

Maybe, just for building the CLI, you can use another service, like Travis or CircleCI, just for CLI. And then upload the binary to the latest tag.

As I've said, I don't know about the internals. Maybe building CLI requires another step to be successfully completed, in which case, my suggestion just renders useless.

@FabianLars
Copy link
Member

FabianLars commented Jul 23, 2022

Maybe we can resurrect the binary-releases repo for this, or would this change nothing about the runner usage limits?

Edit: And i would only start with more popular architectures and not be as throughout as with the node cli, because in this case missing arches can still be installed via cargo install.

@lucasfernog lucasfernog added the status: in progress Implementation is proceeding smoothly label Aug 1, 2022
@lucasfernog lucasfernog self-assigned this Aug 1, 2022
@lucasfernog
Copy link
Member

I don't think changing the repo would enhance it. Opened a PR for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress Implementation is proceeding smoothly type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants