[Feat] tauricon: Allow for additional custom generated icon files.

[phisch]

I have the use-case where I serve my front-end as a tauri app and also as a web-app with PWA support. Instead of maintaining two sets of icons, I would like to just generate one set that is used by everything. This is probably a pretty common use-case.

So it would be nice to have a way to define alternative icon formats, sizes and file-names, that are also generated by tauricon.

Currently, the files to be generated are defined here: https://github.com/tauri-apps/tauricon/blob/dev/src/helpers/tauricon.config.ts

Probably the easiest implementation would be to keep that same structure and provide it via the cli as a json file:

npx @tauri-apps/tauricon icons/logo.svg --target icons --extra icons/extra.json

And then the icons/extra.json could be something like this:

[
  {
    "folder": "../frontend/src/assets/icons",
    "prefix": "icon-",
    "infix": true,
    "suffix": ".png",
    "sizes": [72, 96, 128, 144, 152, 192, 384, 512]
  }
]

What are your thoughts about that?

[khuongduy354]

Can I take this as a newbie? What i'm going to add in this file is:

1. take path to extra.json as a cli argument
2. import the json from path
3. call another tauricon.make() with json as option parameter

[FabianLars]

We always appreciate contributions! The only problem here is that the tauricon (js) package was deprecated and we won't accept any PRs for it anymore (the repo will be archived soon too).
As of tauri-cli v1.1 tauricon is now part of the main cli again - relevant file: https://github.com/tauri-apps/tauri/blob/dev/tooling/cli/src/icon.rs

[FabianLars]

Btw idk how other people see it but i'm not too happy about the prefix/suffix json bloat. What do you guys think about an optional {} in the filename which would be replaced with sizexsize?

  {
    "folder": "../frontend/src/assets/icons",
    "name": "icon-{}.png", // would be icon-72x72.png for example.
    "sizes": [72, 96, 128, 144, 152, 192, 384, 512]
  }

[khuongduy354]

Btw idk how other people see it but i'm not too happy about the prefix/suffix json bloat. What do you guys think about an option {} in the filename which would be replaced with sizexsize?

  {
    "folder": "../frontend/src/assets/icons",
    "name": "icon-{}.png", // would be icon-72x72.png for example.
    "sizes": [72, 96, 128, 144, 152, 192, 384, 512]
  }

this looks cleaner & more straightforward to me.

[lorenzolewis]

One thing I think could be done is to have some smart defaults here that don't require a user to setup a custom json file. For instance, have filenames with mac-512.png, windows-512.png, linux-512.png, etc. could be a useful defaults (but a user could always give alternatives).

[khuongduy354]

Since this issue is in a deprecated repo. I want to clarify it a bit. The relevant file is here.

The goal is to allow custom configs for icons. Something like

yarn tauri icon target-icon.png --ouput icons --config icons/config.json

The configuration for generating icons is currently hardcoded. So, a json format is needed, as I was suggested above:

[
  {
    "folder": "../frontend/src/assets/icons",
    "name": "icon-{}.png", // would be icon-72x72.png for example.
    "sizes": [72, 96, 128, 144, 152, 192, 384, 512]
  }
]

And of course, there'll be default configs if user don't want to customize anything. Is everything all right?

[FabianLars]

As far as i am concerned, the current default output must stay unchanged and this json approach looks fine to me.

That said i didn't really understand Lorenzo's proposal tbh. Also i think there are no other defaults we could/should provide that we don't already have (or will have for new build targets).

Edit: One additional thing: i personally would like to keep it restricted to png for now, if this was in question.

[khuongduy354]

As far as i am concerned, the current default output must stay unchanged and this json approach looks fine to me.

That said i didn't really understand Lorenzo's proposal tbh. Also i think there are no other defaults we could/should provide that we don't already have (or will have for new build targets).

Edit: One additional thing: i personally would like to keep it restricted to png for now, if this was in question.

https://github.com/tauri-apps/tauricon/blob/dev/src/helpers/tauricon.config.ts
do you think the linux defaults above fit ?

[FabianLars]

Yes, otherwise i would've changed it when i ported it to rust :D

But we couldn't change it anyway, because it would be a weird breaking change, and at least the .deb bundle does use these files currently.

As i said, we can't change anything about tauri icons current output, except for the appx images since they are not used right now. But we decided to just keep them anyway 🤷