Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] [macOS] Add an option to configure acceptsFirstMouse #5347

Closed
probablykasper opened this issue Oct 4, 2022 · 5 comments
Closed

[feat] [macOS] Add an option to configure acceptsFirstMouse #5347

probablykasper opened this issue Oct 4, 2022 · 5 comments
Labels
good first issue Good for newcomers status: backlog Issue is ready and we can work on it type: feature request

Comments

@probablykasper
Copy link
Member

Describe the problem

Add a way to pass acceptsFirstMouse to macOS windows

Describe the solution you'd like

Expose tauri-apps/wry#714

Alternatives considered

No response

Additional context

No response
@amrbashir amrbashir added good first issue Good for newcomers status: backlog Issue is ready and we can work on it labels Oct 4, 2022
@probablykasper probablykasper mentioned this issue Oct 4, 2022
Open
@adityanain29
Copy link

Hi, I would like to work on this.
Since I am a beginner i have very little idea about what to do.
Could you guide me on this.
I would learn all the necessities to solve this issue!

@amrbashir
Copy link
Member

@adityanain29 thanks for wanting to contribute, this issue should wait until a new WRY version is published. However you can work on it and change the wry dependency here https://github.com/tauri-apps/tauri/blob/dev/core/tauri-runtime-wry/Cargo.toml to point to the WRY git repo and make your changes. You can also take this PR #5317 as inspiration on how to do it

@adityanain29
Copy link

thanks for the info.
I would try to work accordingly

lucasfernog added a commit that referenced this issue Oct 8, 2022
@lucasfernog
feat(core): add window accept_first_mouse option, closes #5347
2517699
@lucasfernog
Copy link
Member

@adityanain29 sorry I didn't see your message and pushed a PR for this: #5374 :(

@adityanain29
Copy link

Np. I would try to contribute in some other way to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers status: backlog Issue is ready and we can work on it type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@probablykasper @lucasfernog @amrbashir @adityanain29