Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] workspace inheritance does not work #6122

Closed
Tricked-dev opened this issue Jan 21, 2023 · 0 comments
Closed

[bug] workspace inheritance does not work #6122

Tricked-dev opened this issue Jan 21, 2023 · 0 comments
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@Tricked-dev
Copy link

Describe the bug

workspaces do not work
This manifest requires workspace inheritance, but inherit_workspace hasn't been called yet

Reproduction

create a new project and use workspace inheritance.
anything described in here will error cause of cargo-toml https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
it appears like this function needs to be used https://docs.rs/cargo_toml/latest/cargo_toml/struct.Manifest.html#method.inherit_workspace

Expected behavior

Build script should not error when workspaces are being used

Platform and versions

Environment
› OS: EndeavourOS Rolling Release X64
› Node.js: 16.17.1
› npm: 9.3.0
› pnpm: 7.25.1
› yarn: 1.22.19
› rustup: 1.25.1
› rustc: 1.68.0-nightly
› cargo: 1.68.0-nightly
› Rust toolchain: nightly-x86_64-unknown-linux-gnu

Packages
› @tauri-apps/cli [NPM]: 1.2.3
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.4,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,

App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: PReact
› bundler: Vite

App directory structure
├─ public
├─ src-tauri
├─ src
├─ node_modules
└─ dist

Stack trace

Caused by:
  process didn't exit successfully: `/home/tricked/coding/easyhotkeys/target/debug/build/a2m8-61fd4df4ef3fd9d8/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=TAURI_CONFIG
  cargo:rerun-if-changed=tauri.conf.json
  cargo:rustc-cfg=desktop
  cargo:rustc-cfg=dev

  --- stderr
  thread 'main' panicked at 'Err(This manifest requires workspace inheritance, but `inherit_workspace` hasn't been called yet

  Stack backtrace:
     0: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
               at /home/tricked/.cargo/registry/src/github.com-1ecc6299db9ec823/anyhow-1.0.68/src/error.rs:547:25
     1: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/core/src/result.rs:2107:27
     2: tauri_build::try_build
               at /home/tricked/.cargo/registry/src/github.com-1ecc6299db9ec823/tauri-build-1.2.1/src/lib.rs:224:22
     3: build_script_build::main
               at ./build.rs:4:20
     4: core::ops::function::FnOnce::call_once
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/core/src/ops/function.rs:250:5
     5: std::sys_common::backtrace::__rust_begin_short_backtrace
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/sys_common/backtrace.rs:121:18
     6: std::rt::lang_start::{{closure}}
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/rt.rs:166:18
     7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/core/src/ops/function.rs:287:13
     8: std::panicking::try::do_call
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panicking.rs:483:40
     9: std::panicking::try
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panicking.rs:447:19
    10: std::panic::catch_unwind
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panic.rs:140:14
    11: std::rt::lang_start_internal::{{closure}}
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/rt.rs:148:48
    12: std::panicking::try::do_call
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panicking.rs:483:40
    13: std::panicking::try
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panicking.rs:447:19
    14: std::panic::catch_unwind
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panic.rs:140:14
    15: std::rt::lang_start_internal
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/rt.rs:148:20
    16: std::rt::lang_start
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/rt.rs:165:17
    17: main
    18: <unknown>
    19: __libc_start_main
    20: _start)', a2m8/src-tauri/build.rs:4:5
  stack backtrace:
     0: rust_begin_unwind
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/std/src/panicking.rs:575:5
     1: core::panicking::panic_fmt
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/core/src/panicking.rs:64:14
     2: build_script_build::main
               at ./build.rs:4:5
     3: core::ops::function::FnOnce::call_once
               at /rustc/5ce39f42bd2c8bca9c570f0560ebe1fce4eddb14/library/core/src/ops/function.rs:250:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Additional context

https://doc.rust-lang.org/cargo/reference/workspaces.html#the-workspace-section

@Tricked-dev Tricked-dev added status: needs triage This issue needs to triage, applied to new issues type: bug labels Jan 21, 2023
@Tricked-dev Tricked-dev changed the title [bug] [bug] workspaces do not work Jan 21, 2023
@Tricked-dev Tricked-dev changed the title [bug] workspaces do not work [bug] workspace inheritance does not work Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

1 participant