Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[log] Default log path for linux and windows seems unconventional #6809

Closed
tauri-bot opened this issue Apr 27, 2023 · 3 comments · Fixed by #6827
Closed

[log] Default log path for linux and windows seems unconventional #6809

tauri-bot opened this issue Apr 27, 2023 · 3 comments · Fixed by #6827
Assignees
@unknovvn
Labels
good first issue Good for newcomers type: breaking change This issue or pull request will introduce a breaking change and requires major version bump type: bug

Comments

@tauri-bot
Copy link

tauri-bot commented Apr 27, 2023 •
edited by FabianLars
Loading

This issue has been upstreamed from tauri-apps/plugins-workspace#1

~~I believe the convention for storing the log files on Linux is, using the path /var/log. ~~ See edit below
Is there a specific reason for choosing .config instead? (https://github.com/tauri-apps/tauri-plugin-log/blob/dev/src/lib.rs#L106)

Edit: In the rest of the original issue we said var/log/ isn't the solution and instead it should be ~/.local/share/ and %LOCALAPPDATA% respectively.
@tauri-bot tauri-bot added the good first issue Good for newcomers label Apr 27, 2023
@FabianLars FabianLars added type: bug type: breaking change This issue or pull request will introduce a breaking change and requires major version bump good first issue Good for newcomers and removed good first issue Good for newcomers labels Apr 27, 2023
@unknovvn
Copy link
Contributor

@FabianLars I would like to handle this ticket. Please assign it to me

unknovvn added a commit to unknovvn/tauri that referenced this issue May 1, 2023
@unknovvn
fix: default log path for linux and windows updated (fix: tauri-apps#…
d312cf0 
…6809)
@unknovvn unknovvn mentioned this issue May 1, 2023
Merged
13 tasks
unknovvn added a commit to unknovvn/tauri that referenced this issue May 1, 2023
@unknovvn
fix: default log path for linux and windows updated (fix: tauri-apps#…
961dda8 
…6809)
@harivamsi9
Copy link

Hi, Is this ticket still unresolved? If any help is needed, I would like to contribute to the issue

@FabianLars
Copy link
Member

FabianLars commented May 17, 2023 •
edited by amrbashir
Loading

Is this ticket still unresolved?

Yes, but also no: #6827

@amrbashir amrbashir linked a pull request May 21, 2023 that will close this issue
fix: default log path for linux and windows updated (fix: #6809) #6827
Merged
13 tasks
amrbashir pushed a commit that referenced this issue May 21, 2023
@unknovvn
fix: default log path for linux and windows updated (fix: #6809) (#6827)
8e85576 
* fix: default log path for linux and windows updated (fix: #6809)

* fix impl after reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unknovvn unknovvn

Labels
good first issue Good for newcomers type: breaking change This issue or pull request will introduce a breaking change and requires major version bump type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default log path for linux and windows updated (fix: #6809) unknovvn/tauri
5 participants
@unknovvn @FabianLars @harivamsi9 @amrbashir @tauri-bot