Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add Korean as available language for NSIS installers #6906

Closed
Raphiiko opened this issue May 8, 2023 · 5 comments · Fixed by #7010
Closed

[feat] Add Korean as available language for NSIS installers #6906

Raphiiko opened this issue May 8, 2023 · 5 comments · Fixed by #7010
Labels
good first issue Good for newcomers help wanted Help is requested to fix this issue scope: bundler The bundler used in our cli to make installers type: feature request

Comments

@Raphiiko
Copy link
Contributor

Raphiiko commented May 8, 2023

Describe the problem

In my tauri.conf.json, I have Dutch, Japanese and Korean configured as languages under tauri.bundle.windows.nsis.languages. However when building the following error shows for each of these languages when they are included, when bundling the installer:

Error failed to bundle project: Language (Korean/Japanese/Dutch) not implemented. If it is a valid language listed on <https://github.com/kichik/nsis/tree/9465c08046f00ccb6eda985abbdbf52c275c6c4d/Contrib/Language%20files>, please open a Tauri feature request

The three of these languages are all included in the list at the URL given in the error message.

Describe the solution you'd like

I would like to see support added for these three languages, as this would allow me to switch to a single multi-language installer.

Alternatives considered

No response

Additional context

No response

@FabianLars
Copy link
Member

In case you speak any of these languages: My comment in #6852 (comment) applies here too:

for a language to be actually supported we need someone from the community that speaks the requested language to translate Tauri specific strings: https://github.com/tauri-apps/tauri/tree/dev/tooling/bundler/src/bundle/windows/templates/nsis-languages

Contributions much appreciated :)

@FabianLars FabianLars added help wanted Help is requested to fix this issue good first issue Good for newcomers scope: bundler The bundler used in our cli to make installers labels May 8, 2023
@Raphiiko
Copy link
Contributor Author

Raphiiko commented May 8, 2023

I'm afraid Dutch is the only language I can help out with. I've submitted a PR to add support for it in #6907.

FabianLars pushed a commit that referenced this issue May 9, 2023
* Add Dutch to supported NSIS languages

* Added change file

* Reference Dutch language in nsis bundler

* Fix formatting
@amrbashir amrbashir changed the title [feat] Add Dutch, Japanese and Korean as available languages for NSIS installers. [feat] Add Japanese and Korean as available languages for NSIS installers. May 10, 2023
@nathan-fall
Copy link
Contributor

As a Japanese speaker, I created a Japanese translation. #6940

@FabianLars FabianLars changed the title [feat] Add Japanese and Korean as available languages for NSIS installers. [feat] Add Korean as available languages for NSIS installers. May 11, 2023
@Raphiiko Raphiiko changed the title [feat] Add Korean as available languages for NSIS installers. [feat] Add Korean as available language for NSIS installers May 11, 2023
@Mehrbod2002
Copy link
Contributor

I am a Persian speaker and submitted PR : #6965

@soumt-r
Copy link
Contributor

soumt-r commented May 19, 2023

This is my first time contributing on such a big project, so I apologize for any mistakes...

I have completed the translation as a Korean speaker and opened a PR : #7010

@amrbashir amrbashir linked a pull request May 19, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Help is requested to fix this issue scope: bundler The bundler used in our cli to make installers type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants