Skip to content

feat(lib) open link command#10

Merged
lucasfernog merged 1 commit into
devfrom
feature/open-links
Jul 24, 2019
Merged

feat(lib) open link command#10
lucasfernog merged 1 commit into
devfrom
feature/open-links

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Copy Markdown
Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add this command to the whitelist in proton.js template too

@lucasfernog
Copy link
Copy Markdown
Member Author

It's there on lucasfernog/quasar @nothingismagick

@nothingismagick
Copy link
Copy Markdown
Member

but i just realized we have to do that in the other one
lucasfernog/quasar@8a5f842

@lucasfernog lucasfernog merged commit 32b2e95 into dev Jul 24, 2019
@nothingismagick nothingismagick deleted the feature/open-links branch July 24, 2019 22:56
lucasfernog added a commit that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants