Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): esitmated size unit #10086

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jun 18, 2024

Esitmated size unit should be in KB (1024 bytes), not kB (1000 bytes)

@Legend-Master Legend-Master requested a review from a team as a code owner June 18, 2024 14:46
@FabianLars
Copy link
Member

Where did you find that information? All i can find right now seems like it's about 1000 - can't find anything explicit rn so idk (same for when i implemented this).
Also isn't it KB (1000) and KiB (1024)? Or is that a german thing x)

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 19, 2024

From NSIS's website that they said in KB

https://nsis.sourceforge.io/Add_uninstall_information_to_Add/Remove_Programs#:~:text=EstimatedSize%20(DWORD)%20%2D%20The%20size%20of%20the%20installed%20files%20(in%20KB)

Windows uses KB to represent 1024 bytes (you can see this in file explorer)

image

The easiest way to know this is in the installer's choose install directory page, you can see an estimated size, and that size currently doesn't match the size we write to the registry, which will be displayed in Windows's uninstall programs page (also you can install it and see the actual size excluding the uninstaller with the number in uninstall page)

KiB is 1024, kB is 1000, KB can be both XD

https://physics.nist.gov/cuu/Units/binary.html
https://www.nist.gov/pml/owm/metric-si-prefixes

To be honest, Windows uses MB for 1024 x 1024 bytes but in SI unit it should be 1000 x 1000 (2^6) bytes, so...

@FabianLars
Copy link
Member

thanks for the answer :)

@FabianLars FabianLars merged commit 58821fc into tauri-apps:dev Jun 19, 2024
13 of 14 checks passed
@Legend-Master Legend-Master deleted the nsis-estimated-size branch June 20, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants