Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): use runtime ${If} check to clean up deep link on uninstall #10103

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jun 23, 2024

!if is a compile time check, ${If} is the runtime check we needed here

@Legend-Master Legend-Master marked this pull request as ready for review June 23, 2024 03:42
@Legend-Master Legend-Master requested a review from a team as a code owner June 23, 2024 03:42
@amrbashir amrbashir changed the title fix(nsis): can't clean up deep link on uninstall fix(nsis): use runtime ${If} check to clean up deep link on uninstall Jun 24, 2024
@amrbashir amrbashir merged commit faf282c into tauri-apps:dev Jun 24, 2024
13 of 14 checks passed
@Legend-Master Legend-Master deleted the nsis-deep-link-uninstall branch June 24, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants