Skip to content

fix(nsis): use runtime ${If} check to clean up deep link on uninstall#10103

Merged
amrbashir merged 3 commits intotauri-apps:devfrom
Legend-Master:nsis-deep-link-uninstall
Jun 24, 2024
Merged

fix(nsis): use runtime ${If} check to clean up deep link on uninstall#10103
amrbashir merged 3 commits intotauri-apps:devfrom
Legend-Master:nsis-deep-link-uninstall

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jun 23, 2024

!if is a compile time check, ${If} is the runtime check we needed here

@Legend-Master Legend-Master marked this pull request as ready for review June 23, 2024 03:42
@Legend-Master Legend-Master requested a review from a team as a code owner June 23, 2024 03:42
@amrbashir amrbashir changed the title fix(nsis): can't clean up deep link on uninstall fix(nsis): use runtime ${If} check to clean up deep link on uninstall Jun 24, 2024
@amrbashir amrbashir merged commit faf282c into tauri-apps:dev Jun 24, 2024
@Legend-Master Legend-Master deleted the nsis-deep-link-uninstall branch June 24, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants