fix(cli): removed alpha channel from default IOS AppIcons#10114
Merged
amrbashir merged 3 commits intotauri-apps:devfrom Jun 26, 2024
Merged
fix(cli): removed alpha channel from default IOS AppIcons#10114amrbashir merged 3 commits intotauri-apps:devfrom
amrbashir merged 3 commits intotauri-apps:devfrom
Conversation
Member
|
I can attest based on experience that this is true and those icons will be rejected indeed |
Member
|
RemindMe! 1 day "Handle this in tauri icon" (honestly wouldn't mind that reddit bot over here...) |
FabianLars
previously approved these changes
Jun 24, 2024
Member
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
Approving as a witness of Jonas' fight against Apple.
According to Apple's human interface guideline (https://developer.apple.com/design/human-interface-guidelines/app-icons) transparent or icons with alpha channel are not allowed, and will be rejected upon upload to Apple appstore.
Contributor
Author
|
@FabianLars Commit now signed |
amrbashir
requested changes
Jun 26, 2024
Co-authored-by: Amr Bashir <github@amrbashir.me>
lucasfernog
approved these changes
Jun 26, 2024
amrbashir
approved these changes
Jun 26, 2024
amrbashir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Apple's human interface guideline
(https://developer.apple.com/design/human-interface-guidelines/app-icons) transparent or icons with alpha channel are not allowed, and will be rejected upon upload to Apple appstore.