feat: add TSend generic to Channel #10139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
Jun 27, 2024
| @@ -877,7 +877,7 @@ pub(crate) fn init<R: Runtime>() -> TauriPlugin<R> { | |||
| .on_event(|app, e| { | |||
| if let RunEvent::MenuEvent(e) = e { | |||
| if let Some(channel) = app.state::<MenuChannels>().0.lock().unwrap().get(&e.id) { | |||
| let _ = channel.send(&e.id); | |||
| let _ = channel.send(e.id.clone()); | |||
There was a problem hiding this comment.
shouldn't we allow sending a reference?
There was a problem hiding this comment.
I did consider that but send immediately serializes the value, so the string would have been cloned anyway. At least this way you can serialize owned values unlike if only references were supported, but maybe there's a way to support both i haven't considered
lucasfernog
reviewed
Jul 10, 2024
lucasfernog
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
TSendgeneric toipc::Channel. This allows for type-safe calls tosend, and makes it possible fortauri-spectato extract the generic type of channels.The generic isn't used in the
on_messagefunction as that introduces quite a bit more complexity to do so, especially when supporting mobile. This can be implemented later if needed.