fix(core): fix raw invoke body for isolation pattern#10167
Conversation
The `isolation` pattern requests are made using JSON but the payload could be raw bytes, so we send the original `Content-Type` from frontend and make sure to deserialize the payload using that one instead of `Content-Type` from request headers
|
@lucasfernog do you have any idea why is the macOS test failing? |
|
the embed-plist crate can only be used once per binary (by design). So maybe we have to add an option to the generate_context macro to disable it for these test 🤔 (Or imo better yet, if we disable it in test env directly but idk if that works across crates) |
Package Changes Through 8c96c77There are 9 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-bundler with prerelease, @tauri-apps/api with prerelease, tauri-macros with prerelease, tauri-codegen with prerelease, tauri-runtime-wry with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
lucasfernog
left a comment
lucasfernog
left a comment
There was a problem hiding this comment.
you forgot to verify this on an actual app - the JS side was encoding the payload to string
|
I did test it on an actual app, otherwise I wouldn't have found the problem and its fix. I did notice that it was encoding to a string and didn't understand why so I left it as is because the failing code I was testing, worked fine with it. |
|
gooood, well done |
3 participants
The
isolationpattern requests are made using JSON but the payload could be raw bytes, so we send the originalContent-Typefrom frontend and make sure to deserialize the payload using that one instead ofContent-Typefrom request headers