Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): mark AppHandle::restart and process::restart as diverging functions #10171

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

amrbashir
Copy link
Member

closes #10160

@amrbashir amrbashir requested a review from a team as a code owner July 2, 2024 06:11
@Legend-Master
Copy link
Contributor

Should we also mark exit?

@amrbashir
Copy link
Member Author

good call

@amrbashir
Copy link
Member Author

actually it is not possible for exit since it only sends a request to exit, and users are free to prevent that, so we need to either leave it as is or introduce a new method called request_exist and mark the current one as diverging

@Legend-Master
Copy link
Contributor

That makes sense, I only saw that if error process::exit part and assumed it will always exit, seems like it's detecting the error of sending the message

@lucasfernog lucasfernog merged commit a7354f9 into dev Jul 2, 2024
20 checks passed
@lucasfernog lucasfernog deleted the feat/restart-diverging branch July 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] AppHandle::restart should be diverging function (-> !)
4 participants