Skip to content

feat(core): mark AppHandle::restart and process::restart as diverging functions#10171

Merged
lucasfernog merged 1 commit into
devfrom
feat/restart-diverging
Jul 2, 2024
Merged

feat(core): mark AppHandle::restart and process::restart as diverging functions#10171
lucasfernog merged 1 commit into
devfrom
feat/restart-diverging

Conversation

@amrbashir
Copy link
Copy Markdown
Member

closes #10160

@amrbashir amrbashir requested a review from a team as a code owner July 2, 2024 06:11
@Legend-Master
Copy link
Copy Markdown
Contributor

Should we also mark exit?

@amrbashir
Copy link
Copy Markdown
Member Author

good call

@amrbashir
Copy link
Copy Markdown
Member Author

actually it is not possible for exit since it only sends a request to exit, and users are free to prevent that, so we need to either leave it as is or introduce a new method called request_exist and mark the current one as diverging

@Legend-Master
Copy link
Copy Markdown
Contributor

That makes sense, I only saw that if error process::exit part and assumed it will always exit, seems like it's detecting the error of sending the message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] AppHandle::restart should be diverging function (-> !)

4 participants