Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance!(nsis): use !ifmacrodef for installer hooks #10177

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jul 2, 2024

Use !ifmacrodef instead of !ifdef so that the user wouldn't need to use an extra !define just to proxy !macro

https://nsis.sourceforge.io/Reference/!ifmacrodef

@Legend-Master Legend-Master requested a review from a team as a code owner July 2, 2024 11:01
@Legend-Master Legend-Master changed the title enhance(nsis)!: migrate to !ifmacrodef for installer hooks enhance!(nsis): migrate to !ifmacrodef for installer hooks Jul 2, 2024
@Legend-Master Legend-Master changed the title enhance!(nsis): migrate to !ifmacrodef for installer hooks enhance!(nsis): migrate to !ifmacrodef for installer hooks Jul 2, 2024
@amrbashir amrbashir changed the title enhance!(nsis): migrate to !ifmacrodef for installer hooks enhance!(nsis): use !ifmacrodef for installer hooks Jul 3, 2024
@amrbashir amrbashir merged commit 11aa774 into tauri-apps:dev Jul 3, 2024
33 checks passed
@Legend-Master Legend-Master deleted the nsis-ifmacrodef branch July 3, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants