Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1018 Force IPv4 on wget requests #1019

Merged
merged 3 commits into from
Oct 10, 2020
Merged

fix: #1018 Force IPv4 on wget requests #1019

merged 3 commits into from
Oct 10, 2020

Conversation

sanket143
Copy link
Contributor

@sanket143 sanket143 commented Sep 12, 2020

wget sometimes doesn't handle IPv6 well and DNS server may resolve the domain to IPv6 so it'll be better to force IPv4.

https://serverfault.com/questions/290315/why-is-wget-hanging

Resolves #1018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

`wget` sometimes doesn't handle IPv6 well and DNS server so it's better to force IPv4
https://serverfault.com/questions/290315/why-is-wget-hanging
@sanket143 sanket143 requested a review from a team September 12, 2020 08:04
@jbolda
Copy link
Member

jbolda commented Oct 2, 2020

Would you mind inspecting the test failure? Also please include a change file (note the missing checkbox in your PR message).

@sanket143
Copy link
Contributor Author

@jbolda It seems, there is an issue with tauri.js but I'm sorry, I am unable to pin point what exactly is the issue.

@lucasfernog
Copy link
Member

-4 can't come after -O because then the file name becomes -4.

@sanket143 sanket143 requested a review from a team as a code owner October 10, 2020 19:51
@lucasfernog lucasfernog merged commit 6f5667b into tauri-apps:dev Oct 10, 2020
@sanket143 sanket143 deleted the patch-1 branch October 11, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tauri build hangs at wget request
3 participants