Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add working directory to wix's shortcut #1021

Merged
merged 2 commits into from
Sep 24, 2020
Merged

fix: add working directory to wix's shortcut #1021

merged 2 commits into from
Sep 24, 2020

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 14, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

In this screenshot, the one on the left is a shortcut that I created manually and on the right is the shortcut created by wix at C:\ProgramData\Microsoft\Windows\StartMenu\Programs\<app-name>\

image

you can see that the shortcut created by wix doesn't have its Start in (working directory) field set, so it will default to C:\Windows\System32 which will introduce errors when the app tries to read paths relatively.

@amrbashir amrbashir requested a review from a team September 14, 2020 16:26
@amrbashir amrbashir requested a review from a team as a code owner September 24, 2020 00:56
@lucasfernog lucasfernog merged commit 5cf3402 into tauri-apps:dev Sep 24, 2020
@amrbashir amrbashir deleted the fix-wix-shortcut-working-directory branch September 24, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants