fix: add working directory to wix's shortcut#1021
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Sep 24, 2020
amrbashir:fix-wix-shortcut-working-directory
Merged
fix: add working directory to wix's shortcut#1021lucasfernog merged 2 commits intotauri-apps:devfrom amrbashir:fix-wix-shortcut-working-directory
lucasfernog merged 2 commits intotauri-apps:devfrom
amrbashir:fix-wix-shortcut-working-directory
Conversation
lucasfernog
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
In this screenshot, the one on the left is a shortcut that I created manually and on the right is the shortcut created by wix at
C:\ProgramData\Microsoft\Windows\StartMenu\Programs\<app-name>\you can see that the shortcut created by wix doesn't have its
Start in (working directory)field set, so it will default toC:\Windows\System32which will introduce errors when the app tries to read paths relatively.