Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api)!: renamed getCurrent functions to avoid ambiguity #10229

Merged
merged 4 commits into from
Jul 11, 2024
Merged

refactor(api)!: renamed getCurrent functions to avoid ambiguity #10229

merged 4 commits into from
Jul 11, 2024

Conversation

amrbashir
Copy link
Member

closes #10193

@amrbashir amrbashir requested a review from a team as a code owner July 9, 2024 12:44
@FabianLars
Copy link
Member

I dislike this so much as a Rust dev 😭

Legend-Master
Legend-Master reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Legend-Master Legend-Master left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change getAll to getAllWindows etc?

Also probably need to update examples

@sanbei101
Copy link

That's a really good idea

@amrbashir
Copy link
Member Author

Should we also change getAll to getAllWindows etc?

Also probably need to update examples

done

FabianLars
FabianLars approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making github acknowledge Tony's review

@amrbashir amrbashir merged commit 2b1ceb4 into dev Jul 11, 2024
15 checks passed
@amrbashir amrbashir deleted the refactor/api/get-current-abiguity branch July 11, 2024 11:26
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

@Legend-Master Legend-Master Legend-Master approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Distinct names for all the different getCurrent functions in the frontend API
4 participants
@amrbashir @FabianLars @sanbei101 @Legend-Master