Skip to content

feat: add granular size constraints APIs#10242

Merged
amrbashir merged 7 commits intodevfrom
feat/split-min-max-constraints
Jul 17, 2024
Merged

feat: add granular size constraints APIs#10242
amrbashir merged 7 commits intodevfrom
feat/split-min-max-constraints

Conversation

@amrbashir
Copy link
Copy Markdown
Member

closes #7075
closes #10227

@amrbashir amrbashir requested a review from a team as a code owner July 10, 2024 11:28
FabianLars
FabianLars previously approved these changes Jul 10, 2024
Comment thread core/tauri-runtime-wry/src/lib.rs Outdated
@FabianLars FabianLars dismissed their stale review July 10, 2024 13:02

oh no, i'm also blind to typos now D:

@Legend-Master
Copy link
Copy Markdown
Contributor

Should we also expose this to js side?

@Legend-Master
Copy link
Copy Markdown
Contributor

Testing with "windows": [{"minWidth": 500,"width": 800,"label": "main1"}], in the config file of api example, seems like the size of that window gets capped at 500px and can't be resized, can resize height though

@amrbashir
Copy link
Copy Markdown
Member Author

Should we also expose this to js side?

done

@amrbashir
Copy link
Copy Markdown
Member Author

Testing with "windows": [{"minWidth": 500,"width": 800,"label": "main1"}], in the config file of api example, seems like the size of that window gets capped at 500px and can't be resized, can resize height though

was a small typo, that set max_width with the value of min_width, it is now fixed

Comment thread core/tauri-runtime-wry/src/lib.rs Outdated
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@Legend-Master
Copy link
Copy Markdown
Contributor

was a small typo, that set max_width with the value of min_width, it is now fixed

oh no, i'm also blind to typos now D:

🙃

Comment thread tooling/api/src/window.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 15, 2024

Package Changes Through a7c9e5e

There are 5 changes which include @tauri-apps/api with prerelease, tauri-bundler with prerelease, tauri with prerelease, tauri-runtime with prerelease, tauri-runtime-wry with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.0-beta.15 2.0.0-beta.16
tauri-bundler 2.0.1-beta.18 2.0.1-beta.19
tauri-runtime 2.0.0-beta.20 2.0.0-beta.21
tauri-runtime-wry 2.0.0-beta.20 2.0.0-beta.21
tauri 2.0.0-beta.24 2.0.0-beta.25
@tauri-apps/cli 2.0.0-beta.22 2.0.0-beta.23
tauri-cli 2.0.0-beta.22 2.0.0-beta.23

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Comment thread tooling/api/src/window.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] The minWidth of the window is invalid. minWidth has no effect without minHeight in tauri windows config

3 participants