Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add granular size constraints APIs #10242

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Conversation

amrbashir
Copy link
Member

closes #7075
closes #10227

@amrbashir amrbashir requested a review from a team as a code owner July 10, 2024 11:28
FabianLars
FabianLars previously approved these changes Jul 10, 2024
@FabianLars FabianLars dismissed their stale review July 10, 2024 13:02

oh no, i'm also blind to typos now D:

@Legend-Master
Copy link
Contributor

Should we also expose this to js side?

@Legend-Master
Copy link
Contributor

Testing with "windows": [{"minWidth": 500,"width": 800,"label": "main1"}], in the config file of api example, seems like the size of that window gets capped at 500px and can't be resized, can resize height though

@amrbashir
Copy link
Member Author

Should we also expose this to js side?

done

@amrbashir
Copy link
Member Author

Testing with "windows": [{"minWidth": 500,"width": 800,"label": "main1"}], in the config file of api example, seems like the size of that window gets capped at 500px and can't be resized, can resize height though

was a small typo, that set max_width with the value of min_width, it is now fixed

Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@Legend-Master
Copy link
Contributor

was a small typo, that set max_width with the value of min_width, it is now fixed

oh no, i'm also blind to typos now D:

🙃

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Package Changes Through a7c9e5e

There are 5 changes which include @tauri-apps/api with prerelease, tauri-bundler with prerelease, tauri with prerelease, tauri-runtime with prerelease, tauri-runtime-wry with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.0-beta.15 2.0.0-beta.16
tauri-bundler 2.0.1-beta.18 2.0.1-beta.19
tauri-runtime 2.0.0-beta.20 2.0.0-beta.21
tauri-runtime-wry 2.0.0-beta.20 2.0.0-beta.21
tauri 2.0.0-beta.24 2.0.0-beta.25
@tauri-apps/cli 2.0.0-beta.22 2.0.0-beta.23
tauri-cli 2.0.0-beta.22 2.0.0-beta.23

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

tooling/api/src/window.ts Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit da25f73 into dev Jul 17, 2024
25 checks passed
@amrbashir amrbashir deleted the feat/split-min-max-constraints branch July 17, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants