fix(bundler): warning for self contained updaters #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianLars
reviewed
Jul 15, 2024
| @@ -161,7 +161,15 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<Bundle>> { | |||
| package_type: PackageType::Updater, | |||
| bundle_paths: updater_paths, | |||
| }); | |||
| } else { | |||
| } else if updater.v1_compatible | |||
| || !package_types.iter().any(|package_type| { | |||
There was a problem hiding this comment.
Hmm, maybe we need this to be dynamic depending on the currently built platform, but we could also add it later idc - edit: or maybe it's too early for me rn and it doesn't matter at this point in the code
There was a problem hiding this comment.
To be honest, the way this thing is currently structured is all about maintaining the old code path for v1 zipped updaters
FabianLars
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from #10188, bundler warns about no updater-enabled targets were built for self contained updaters like app image, nsis, msi