changes(nsis): move pre hooks before kill app #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
NSIS_HOOK_PREINSTALLandNSIS_HOOK_PREUNINSTALLrun beforeCheckIfAppIsRunning(which checks if the app is running and asks the user if they want to kill the app)pre-install an pre-uninstall hooks should run before everything else we do, this gives the user the ability to run their own check app running logics (in my case I registered a service with the same name and I need to clean it up before
CheckIfAppIsRunning)If the user wants to have the app killed before their hook, they can call
CheckIfAppIsRunningin their hooks