fix(macos): set default title-bar style to Visible, close #10225
#10297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pewsheen
force-pushed
the
fix/macos-default-visible-titlebar
branch
from
cfe3945 to
96d0a34
Compare
pewsheen
force-pushed
the
fix/macos-default-visible-titlebar
branch
from
96d0a34 to
5a13d74
Compare
amrbashir
requested changes
Jul 17, 2024
|
|
||
| #[cfg(target_os = "macos")] | ||
| { | ||
| builder = builder.title_bar_style(TitleBarStyle::Visible); |
There was a problem hiding this comment.
This sounds like a workaround, because it breaks if user choses another title bar style. Let's add a comment why this workaround exists and backlink to the issue. Also add a TODO to find a proper fix.
amrbashir
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #10225
I'm unsure what happened inside, but setting it to
Visiblecan fix the issue.It also happened when creating the
WKWebViewin the Xcode project, so I guess it depends on how the OS implements the window.