Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: core plugin permissions are now prefixed core:, closes #10359 #10390

Merged
merged 9 commits into from
Jul 30, 2024

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner July 25, 2024 20:58
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Package Changes Through c902dc1

There are 5 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-plugin with prerelease, tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-beta.19 2.0.0-beta.20
tauri-bundler 2.0.1-beta.19 2.0.1-beta.20
tauri-runtime 2.0.0-beta.21 2.0.0-beta.22
tauri-runtime-wry 2.0.0-beta.21 2.0.0-beta.22
tauri-codegen 2.0.0-beta.19 2.0.0-beta.20
tauri-macros 2.0.0-beta.19 2.0.0-beta.20
tauri-plugin 2.0.0-beta.19 2.0.0-beta.20
tauri-build 2.0.0-beta.19 2.0.0-beta.20
tauri 2.0.0-beta.25 2.0.0-beta.26
@tauri-apps/cli 2.0.0-beta.23 2.0.0-beta.24
tauri-cli 2.0.0-beta.23 2.0.0-beta.24

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@tillmann-crabnebula
Copy link
Contributor

Do we want to introduce the core:default permission set in this PR as well?
This one would combine all core plugins default permissions.

Copy link
Contributor

@tillmann-crabnebula tillmann-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. Some small observations we should fix.

Edit: Also some docstring lints to fix: https://github.com/tauri-apps/tauri/actions/runs/10101389779/job/27934877226?pr=10390#step:6:529

@lucasfernog
Copy link
Member Author

Do we want to introduce the core:default permission set in this PR as well? This one would combine all core plugins default permissions.

Pushed, but had to make a little workaround because we do not support cross-plugin referencing of permissions (we decided we wouldn't define plugin dependencies here to simplify the work).

@lucasfernog lucasfernog merged commit 758d28c into dev Jul 30, 2024
34 checks passed
@lucasfernog lucasfernog deleted the refactor/core-plugin-namespace branch July 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants