Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): allow skipping rustfmt project reformatting when adding a plugin #10457

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

mmvanheusden
Copy link
Contributor

Normally, each time, for example pnpm tauri add dialog is ran, the project is automatically reformatted using rustfmt (cargo fmt).

I added an option allowing it to be skipped. Maybe it is even better to have it removed all together?
I don't think adding a plugin to a project should automatically reformat all your code. Those two things are entirely unrelated.

@mmvanheusden mmvanheusden requested a review from a team as a code owner August 2, 2024 15:24
tooling/cli/src/add.rs Outdated Show resolved Hide resolved
tooling/cli/src/add.rs Outdated Show resolved Hide resolved
tooling/cli/src/add.rs Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 10, 2024

Package Changes Through 26774ab

There are 4 changes which include tauri-build with prepatch, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit bba1a44 into tauri-apps:dev Aug 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants