fix(cli): v1 migration should add the updater plugin if it is enabled #10481
Conversation
Package Changes Through f681837There are 3 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| @@ -114,6 +114,10 @@ fn migrate_config(config: &mut Value) -> Result<MigratedConfig> { | |||
| process_updater(tauri_config, &mut plugins)?; | |||
| } | |||
|
|
|||
| if plugins.contains_key("updater") { | |||
There was a problem hiding this comment.
shouldn't this be if let Some(updater) = tauri_config.remove("updater") { (moved into the above block)?
There was a problem hiding this comment.
I didn't want to add the migrated argument (lazy) but it's indeed cleaner that way.. pushed
There was a problem hiding this comment.
ah tbh i just missed the process_updater line above that (its comment is saying cli btw) so i thought the code is actually incorrect.
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
No description provided.