Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fails to build universal fat binary if main bin is renamed to another name #10550

Merged
merged 3 commits into from
Aug 11, 2024
Merged

fix: fails to build universal fat binary if main bin is renamed to another name #10550

merged 3 commits into from
Aug 11, 2024

Conversation

anatawa12
Copy link
Contributor

Fixes #10549

@anatawa12 anatawa12 requested a review from a team as a code owner August 9, 2024 13:36
@anatawa12 anatawa12 mentioned this pull request Aug 9, 2024
Merged
lucasfernog
lucasfernog previously approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 10, 2024 •
edited
Loading

Package Changes Through 27a9e3a

There are 4 changes which include tauri-build with prepatch, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@anatawa12
Copy link
Contributor Author

I feel the lint failure is not came from my code so I've merged dev branch

@lucasfernog lucasfernog merged commit 4bfe488 into tauri-apps:dev Aug 11, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2024
Merged
@anatawa12 anatawa12 deleted the universal-bin-build-fails branch August 13, 2024 07:05
@anatawa12 anatawa12 mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] failed to run lipo if main bin is renamed to another name
2 participants
@anatawa12 @lucasfernog