Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android): Remove targetSdk from gradle config #10558

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

ahqsoftwares
Copy link
Contributor

This PR aims to fix the following warning

w: file:///C:/Users/Windows/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tauri-2.0.0-rc.2/mobile/android/build.gradle.kts:12:9: 'targetSdk: Int?' is deprecated. Will be removed from library DSL in v9.0. Use testOptions.targetSdk or/and lint.targetSdk instead

It removes targetSdk from the gradle kts files as it is deprecated and will be removed in DSL v9.0

@ahqsoftwares ahqsoftwares requested a review from a team as a code owner August 10, 2024 14:54
@ahqsoftwares ahqsoftwares changed the title refactor(android): Remove targetSdk for gradle config refactor(android): Remove targetSdk from gradle config Aug 10, 2024
Copy link

socket-security bot commented Aug 10, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Contributor

github-actions bot commented Aug 10, 2024

Package Changes Through 9620b87

There are 5 changes which include tauri-build with prepatch, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
@lucasfernog
Copy link
Member

we also need to make this change on the plugins workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants