Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): properly exit with code 1 on panic when running with bun #10572

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

lucasfernog
Copy link
Member

Found out about this when testing #10569 (maybe bun handles this differently when using NAPI?)

@lucasfernog lucasfernog requested a review from a team as a code owner August 11, 2024 22:45
Copy link
Contributor

Package Changes Through f9d98f7

There are 6 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog changed the title fix(cli): properly exit with code 0 on panic when running with bun fix(cli): properly exit with code 1 on panic when running with bun Aug 11, 2024
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to do anything about it? sounds like a bug in bun and we should just report it to bun instead of adding a workaround?

@lucasfernog
Copy link
Member Author

do we really need to do anything about it? sounds like a bug in bun and we should just report it to bun instead of adding a workaround?

I'm not even sure if it's really a bug in bun, or just a ""feature"" of Node.js 😂 makes sense anyway for us to catch_unwind here, we're running Rust from another language

@lucasfernog lucasfernog merged commit 41c7a66 into dev Aug 13, 2024
14 checks passed
@lucasfernog lucasfernog deleted the fix/cli-panic-error branch August 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants