feat: TAURI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe.#10588
Merged
amrbashir merged 4 commits intotauri-apps:devfrom Aug 13, 2024
Merged
Conversation
…path to signtool.exe.
lucasfernog
reviewed
Aug 13, 2024
lucasfernog
changed the title
TAUIRI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe.TAURI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe.
lucasfernog
approved these changes
Aug 13, 2024
Contributor
Package Changes Through 5a043d7There are 7 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease, tauri with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Aug 13, 2024
amrbashir
added a commit
that referenced
this pull request
Aug 13, 2024
immediately after merging #10588 I noticed that the variable name might be a bit ambigious and could cause confusion on other pl atforms other than Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #10583
The issue was closed with misreading of my issue so I'm creating PR here.
If the issue should be closed even has no misreading, feel free to close this PR.