Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TAURI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe. #10588

Merged

Conversation

anatawa12
Copy link
Contributor

Implements #10583

The issue was closed with misreading of my issue so I'm creating PR here.
If the issue should be closed even has no misreading, feel free to close this PR.

@anatawa12 anatawa12 requested a review from a team as a code owner August 13, 2024 03:45
tooling/bundler/src/bundle/windows/sign.rs Outdated Show resolved Hide resolved
.changes/cli-signtool-path.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog changed the title feat: TAUIRI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe. feat: TAURI_SIGNTOOL_PATH environment variable for specifying the path to signtool.exe. Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Package Changes Through 5a043d7

There are 7 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease, tauri with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir merged commit f8d658e into tauri-apps:dev Aug 13, 2024
15 checks passed
@anatawa12 anatawa12 deleted the feat-manually-specify-signtool-exe branch August 13, 2024 11:50
amrbashir added a commit that referenced this pull request Aug 13, 2024
immediately after merging #10588 I noticed that the variable name might be a bit ambigious and could cause confusion on other pl atforms other than Windows
lucasfernog pushed a commit that referenced this pull request Aug 14, 2024
…H` (#10595)

immediately after merging #10588 I noticed that the variable name might be a bit ambigious and could cause confusion on other pl atforms other than Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants