fix(cli): builtin dev server should also be forwarded for Android #10600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the CLI to persist the "merge config" across mobile command usage (required to pull this config on the xcode and android studio build scripts). This is required because the builtin dev server makes modifications to the Tauri config (devUrl rewrite) and we need to detect that to forward the dev URL port to Android using ADB. Also adds a warning on iOS when using `dev --open`: you need the `--host` option to run on physical devices.
Package Changes Through 6f050b4There are 7 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease, tauri with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Aug 13, 2024
lucasfernog
added a commit
that referenced
this pull request
Aug 14, 2024
just applying the change from #10600 to xcode to fix the linked issue :)
lucasfernog
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the CLI to persist the "merge config" across mobile command usage (required to pull this config on the xcode and android studio build scripts). This is required because the builtin dev server makes modifications to the Tauri config (devUrl rewrite) and we need to detect that to forward the dev URL port to Android using ADB.
Also adds a warning on iOS when using
dev --open: you need the--hostoption to run on physical devices.