refactor(api)!: change window label getters to be async ref #5380#10630
Merged
lucasfernog merged 2 commits intodevfrom Aug 15, 2024
Merged
refactor(api)!: change window label getters to be async ref #5380#10630lucasfernog merged 2 commits intodevfrom
lucasfernog merged 2 commits intodevfrom
Conversation
using initialization scripts to have a dynamic data (available windows) is a bad idea and we should drop that before going v2 stable
Contributor
Package Changes Through 368beedThere are 8 changes which include tauri-build with prepatch, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-bundler with prerelease, tauri with prerelease, @tauri-apps/api with prepatch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
Author
|
closes #10256 |
amrbashir
previously approved these changes
Aug 15, 2024
.changes/get-window-async.md
Outdated
| "@tauri-apps/api": patch:breaking | ||
| --- | ||
|
|
||
| Changed `WebviewWindow.getAll`, `WebviewWindow.getByLabel`, `getAllWebviewWindows`, `WebviewWindow.getFocusedWindow`, |
Member
There was a problem hiding this comment.
getFocusedWindow is already async
lucasfernog
commented
Aug 15, 2024
amrbashir
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using initialization scripts to have a dynamic data (available windows) is a bad idea and we should drop that before going v2 stable
closes #10256