Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): synchronize pbxproj and export options, handle cert on build #10669

Merged
merged 13 commits into from
Aug 21, 2024

Conversation

lucasfernog
Copy link
Member

  • adds a pbxproj parser and writer (very simple, just for the objects we actually need)
  • changed codesign modifications from ios init to ios build
  • synchronize pbxproj with export options so that CLI build works if you change the xcode project manually

- adds a pbxproj parser and writer (very simple, just for the objects we actually need)
- changed codesign modifications from ios init to ios build
- synchronize pbxproj with export options so that CLI build works if you change the xcode project manually
@lucasfernog lucasfernog requested a review from a team as a code owner August 18, 2024 15:04
Copy link
Contributor

github-actions bot commented Aug 18, 2024

Package Changes Through 155182b

There are 3 changes which include tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.5 2.0.0-rc.6
tauri-bundler 2.0.1-rc.4 2.0.1-rc.5
tauri-runtime 2.0.0-rc.5 2.0.0-rc.6
tauri-runtime-wry 2.0.0-rc.5 2.0.0-rc.6
tauri-codegen 2.0.0-rc.5 2.0.0-rc.6
tauri-macros 2.0.0-rc.5 2.0.0-rc.6
tauri-plugin 2.0.0-rc.5 2.0.0-rc.6
tauri-build 2.0.0-rc.5 2.0.0-rc.6
tauri 2.0.0-rc.5 2.0.0-rc.6
@tauri-apps/cli 2.0.0-rc.6 2.0.0-rc.7
tauri-cli 2.0.0-rc.6 2.0.0-rc.7

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

amrbashir
amrbashir previously approved these changes Aug 21, 2024
None
}
(None, Some(_)) => {
log::warn!("The IOS_CERTIFICATE_PASSWORD environment variable is set but not IOS_CERTIFICATE. Ignoring the certificate...");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably skip this warning, doesn't make sense to check IOS_CERTIFCATE_PASSWORD and not IOS_CERTIFICATE

@lucasfernog lucasfernog merged commit da8c9a7 into dev Aug 21, 2024
17 checks passed
@lucasfernog lucasfernog deleted the refactor/ios-cert-sync branch August 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants