-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): allow hyphens and underscores on identifiers, closes #9707 #10700
Conversation
Package Changes Through 003d8e8There are 5 changes which include tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-build with prerelease, tauri-runtime-wry with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
needs a wry fix i think |
Needs tauri-apps/tao#964 |
core/tauri-build/src/lib.rs
Outdated
println!("cargo:rustc-env=TAURI_ANDROID_PACKAGE_NAME_APP_NAME={w}"); | ||
} else { | ||
android_package_prefix.push_str(w); | ||
android_package_prefix.push_str(&w.replace(['_', '-'], "_1")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TAURI_ANDROID_PACKAGE_NAME_APP_NAME
seemed to be replaced in
tauri/core/tauri-macros/src/mobile.rs
Lines 46 to 51 in 762cf31
let app_name = get_env_var( | |
"TAURI_ANDROID_PACKAGE_NAME_APP_NAME", | |
|r| r.replace('-', "_"), | |
&mut error, | |
&function, | |
); |
android_binding!
Should we move that replacement to L479 as well? So that we can do it in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, pushed
Looks like we don't need it? Other than this one, I think it's good to merge |
yeah it was just the tao thing |
No description provided.