fix(cli): ensure gradlew is executable and does not use CRLF#10751
Merged
lucasfernog merged 5 commits intodevfrom Aug 23, 2024
Merged
fix(cli): ensure gradlew is executable and does not use CRLF#10751lucasfernog merged 5 commits intodevfrom
lucasfernog merged 5 commits intodevfrom
Conversation
Contributor
Package Changes Through 4429a93There are 5 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-codegen with prerelease, tauri-bundler with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
previously approved these changes
Aug 23, 2024
tooling/cli/src/mobile/mod.rs
Outdated
| let mut permissions = metadata.permissions(); | ||
| let is_executable = permissions.mode() & 0o111 != 0; | ||
| if !is_executable { | ||
| permissions.set_mode(0o755); |
Member
There was a problem hiding this comment.
should we preserve previous permissions and only add 0o111 for execution bit? instead of always setting 0o755
amrbashir
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required due to a limitation of our template engine, which cannot preserve file permissions.
When you generate the Android project on Android and commit it, it will fail to run in CI (if you are running on UNIX) because it will lack the executable permissions. Plus if it uses CRLF it will also fail to execute (
/usr/bin/env: ‘sh\r’: No such file or directory).