Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): clippy warnings, simplify embed_plist usage #10844

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner August 31, 2024 11:06
Copy link
Contributor

github-actions bot commented Aug 31, 2024

Package Changes Through 18cf513

There are 6 changes which include tauri with prerelease, tauri-runtime-wry with prerelease, tauri-utils with prerelease, tauri-codegen with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.7 2.0.0-rc.8
tauri-bundler 2.0.1-rc.7 2.0.1-rc.8
tauri-runtime 2.0.0-rc.7 2.0.0-rc.8
tauri-runtime-wry 2.0.0-rc.7 2.0.0-rc.8
tauri-codegen 2.0.0-rc.7 2.0.0-rc.8
tauri-macros 2.0.0-rc.6 2.0.0-rc.7
tauri-plugin 2.0.0-rc.7 2.0.0-rc.8
tauri-build 2.0.0-rc.7 2.0.0-rc.8
tauri 2.0.0-rc.8 2.0.0-rc.9
@tauri-apps/cli 2.0.0-rc.10 2.0.0-rc.11
tauri-cli 2.0.0-rc.9 2.0.0-rc.10

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Comment on lines 32 to 33
#[cfg(not(any(windows, target_os = "linux")))]
let _app = app;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this complicates the example a bit, I'd rather just add #![allow(unused)] at the top

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add it inline.. i hate suppressing warns globally ;D

amrbashir
amrbashir previously approved these changes Sep 2, 2024
@amrbashir amrbashir merged commit 27d0183 into dev Sep 2, 2024
24 checks passed
@amrbashir amrbashir deleted the fix/clippy-warns branch September 2, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants