Skip to content

fix(core): Mark identifier as a required field. - #10946

Merged
lucasfernog merged 3 commits into
devfrom
fix/identifier-required
Sep 10, 2024
Merged

lucasfernog merged 3 commits into
devfrom
fix/identifier-required

Conversation

@FabianLars

Copy link
Copy Markdown
Member

Noticed in https://discord.com/channels/616186924390023171/1276353618093674518 where only the .msi build failed to build even though bundle.publisher was set. If both publisher and identifier are set it correctly uses publisher and since identifier is required with this pr i don't really care about that potential issue.

@FabianLars
FabianLars requested a review from a team as a code owner September 10, 2024 10:34
@github-actions

github-actions Bot commented Sep 10, 2024 •

Copy link
Copy Markdown
Contributor

Package Changes Through 4ca6d70

There are 1 changes which include tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.9 2.0.0-rc.10
tauri-bundler 2.0.1-rc.9 2.0.1-rc.10
tauri-runtime 2.0.0-rc.9 2.0.0-rc.10
tauri-runtime-wry 2.0.0-rc.9 2.0.0-rc.10
tauri-codegen 2.0.0-rc.9 2.0.0-rc.10
tauri-macros 2.0.0-rc.8 2.0.0-rc.9
tauri-plugin 2.0.0-rc.9 2.0.0-rc.10
tauri-build 2.0.0-rc.9 2.0.0-rc.10
tauri 2.0.0-rc.10 2.0.0-rc.11
@tauri-apps/cli 2.0.0-rc.12 2.0.0-rc.13
tauri-cli 2.0.0-rc.11 2.0.0-rc.12

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhhh i didn't even know about this one!

@lucasfernog
lucasfernog merged commit 0a47bf0 into dev Sep 10, 2024
@lucasfernog
lucasfernog deleted the fix/identifier-required branch September 10, 2024 13:08
@Legend-Master

Copy link
Copy Markdown
Contributor

This change itself has nothing wrong, but now files like tauri.windows.conf.json that's supposed to be merged into the main config file will get a Missing property "identifier". warning which might cause confusions

@FabianLars

Copy link
Copy Markdown
Member Author

Shit forgot to mention that. 😳

but idk I'd rather have it required in the Schema for more tools to pick up the reqs than having some custom validation that only triggers on build.

@Legend-Master

Copy link
Copy Markdown
Contributor

Maybe generate another schema file without the requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants