fix(bundler): store and remove old main binary on updates if main binary name has change #10962
Conversation
…ary name has change
Package Changes Through 7e5d257There are 2 changes which include tauri-bundler with prerelease, tauri-cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
force-pushed
the
feat/store-and-remove-main-binary-name
branch
from
33c85f2
to
ce11113
Compare
| @@ -637,6 +637,15 @@ Section Install | |||
| WriteRegStr SHCTX "${UNINSTKEY}" $MultiUser.InstallMode 1 | |||
| !endif | |||
|
|
|||
| ; Remove old main binary if it doesn't match new main binary name | |||
| ReadRegStr $0 SHCTX "${UNINSTKEY}" "MainBinaryName" | |||
There was a problem hiding this comment.
does this delete the binary on each install? since the v2 installer also uses the same key.. maybe we should use a different one for v2?
There was a problem hiding this comment.
no this key will be removed when running the uninstaller, so it is only valid when doing updates. It has to be the same key for every installer (whether v1 or v2) so it can detect main binary name changes on updates
ref: #10952