Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler/wix): use product name to generate UpgradeCode for MSI #10967

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

amrbashir
Copy link
Member

The upgrade code generation was changed due to an accidental regression in #9375. Previously UpgradeCode was calculated using the main binary name which was <product_name>.exe, but #9375 changed the default main binary name to <cargo-crate-name>.exe and thus a different UpgradeCode was generetad.

This PR reverts this change to use product name for UpgradeCode generation.

The upgrade code generation was changed due to an accidental regression in #9375. Previously `UpgradeCode` was calculated using the main binary name which was `<product_name>.exe`, but #9375 changed the default main binary name to `<cargo-crate-name>.exe` and thus a different UpgradeCode was generetad.

This PR reverts this change to use product name for `UpgradeCode` generation.
@amrbashir amrbashir requested a review from a team as a code owner September 11, 2024 23:05
Copy link
Contributor

Package Changes Through 4968397

There are 2 changes which include tauri-bundler with prerelease, tauri-cli with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1-rc.10 2.0.1-rc.11
@tauri-apps/cli 2.0.0-rc.13 2.0.0-rc.14
tauri-cli 2.0.0-rc.12 2.0.0-rc.13

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit 7eb1171 into dev Sep 12, 2024
14 checks passed
@lucasfernog lucasfernog deleted the fix/wix-upgrade-code branch September 12, 2024 12:22
amrbashir added a commit that referenced this pull request Sep 13, 2024
… future updates (#10952)

* feat(bundler): store main binary name to be used in registry for furture updates

* revert wix changes as leftover binaries are fixed by #10967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants