Skip to content

fix(core): Use productName for FileDescription#10975

Merged
amrbashir merged 4 commits into
devfrom
fix/win/filedescription
Sep 12, 2024
Merged

fix(core): Use productName for FileDescription#10975
amrbashir merged 4 commits into
devfrom
fix/win/filedescription

Conversation

@FabianLars

Copy link
Copy Markdown
Member

fixes #10968
fixes #10890

There's also a VersionInfo FileDescription in the nsis installer template but i didn't see this being applied/used anywhere so i didn't touch it yet. Maybe windows 7 shows it still? From what i saw on StackOverflow, VersionInfo isn't really used since Vista but idk.

@FabianLars FabianLars requested a review from a team as a code owner September 12, 2024 15:17
@github-actions

github-actions Bot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Package Changes Through 65c9f03

There are 3 changes which include tauri-bundler with prerelease, tauri-cli with prerelease, tauri-build with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1-rc.10 2.0.1-rc.11
tauri-build 2.0.0-rc.10 2.0.0-rc.11
tauri 2.0.0-rc.11 2.0.0-rc.12
@tauri-apps/cli 2.0.0-rc.13 2.0.0-rc.14
tauri-cli 2.0.0-rc.12 2.0.0-rc.13

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir

Copy link
Copy Markdown
Member

Lets change the NSIS as well, for consistency

@FabianLars

Copy link
Copy Markdown
Member Author

tbh was almost considering to remove it. I can't even see the value it sets with things like exiftool. Any idea where it's used/Where i can see it? Even started my win7 vm for this.

@amrbashir

Copy link
Copy Markdown
Member

It is not really used in anything, it can only be visible in the Details tab when checking the properties of the installer executable. I am fine with removing as well, but I think we should just update it to use productName

@FabianLars

Copy link
Copy Markdown
Member Author

ffs, i didn't use the damn local cli/bundler when testing this, holy shit.

@martpie

martpie commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug][File Association] "Open with" displays the app description instead of the app name on Windows [feat] Add windows settings description text

3 participants