Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: rename plugin::PermissionState::Unknown to plugin::PermissionState::Prompt #10978

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner September 12, 2024 20:36
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Package Changes Through 68d12f8

There are 4 changes which include tauri-bundler with prerelease, tauri-cli with prerelease, tauri with prerelease, tauri-build with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.1-rc.10 2.0.1-rc.11
tauri-build 2.0.0-rc.10 2.0.0-rc.11
tauri 2.0.0-rc.11 2.0.0-rc.12
@tauri-apps/cli 2.0.0-rc.13 2.0.0-rc.14
tauri-cli 2.0.0-rc.12 2.0.0-rc.13

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

amrbashir
amrbashir previously approved these changes Sep 12, 2024
@@ -923,7 +923,7 @@ impl std::fmt::Display for PermissionState {
Self::Granted => write!(f, "granted"),
Self::Denied => write!(f, "denied"),
Self::PromptWithRationale => write!(f, "prompt-with-rationale"),
Self::Unknown => write!(f, "Unknown"),
Self::Unknown => write!(f, "prompt"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the variant be named Prompt then?

@lucasfernog lucasfernog changed the title fix(core): plugin::PermissionState::Unknown wrong display impl refactor(core)!: rename plugin::PermissionState::Unknown to plugin::PermissionState::Prompt Sep 13, 2024
@lucasfernog lucasfernog merged commit fe5ff12 into dev Sep 13, 2024
20 checks passed
@lucasfernog lucasfernog deleted the fix/permission-state-unknown-display branch September 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants